Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Java Service Wrapper 3.5.46 (new formula) #90008

Closed
wants to merge 6 commits into from
Closed

Java Service Wrapper 3.5.46 (new formula) #90008

wants to merge 6 commits into from

Conversation

VonUniGE
Copy link
Contributor

  • Have you followed the guidelines for contributing?
  • Have you ensured that your commits follow the commit style guide?
  • Have you checked that there aren't other open pull requests for the same formula update/change?
  • Have you built your formula locally with brew install --build-from-source <formula>, where <formula> is the name of the formula you're submitting?
  • Is your test running fine brew test <formula>, where <formula> is the name of the formula you're submitting?
  • Does your build pass brew audit --strict <formula> (after doing brew install --build-from-source <formula>)? If this is a new formula, does it pass brew audit --new <formula>?

Java Service Wrapper 3.5.46 is the fist Apple silicon compatible version. It can be used to start Sonarqube on Apple Silicon as discussed in #88380

@BrewTestBot BrewTestBot added java Java use is a significant feature of the PR or issue new formula PR adds a new formula to Homebrew/homebrew-core labels Nov 26, 2021
@carlocab carlocab added the CI-no-fail-fast Continue CI tests despite failing GitHub Actions matrix builds. label Nov 26, 2021
carlocab
carlocab reviewed Nov 26, 2021
View reviewed changes
Copy link
Member

@carlocab carlocab left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Nice work here. A few comments.

Formula/java-service-wrapper.rb

def install
ENV["JAVA_HOME"] = Formula["openjdk@11"].opt_prefix
system "ant", "-Dbits=64", "-Djavac.target.version=1.6"
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

A comment explaining the 1.6 here would be good.

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Ok, done.

Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Is there a potential risk something breaks as upstream shipped with version 1.4 and probably never tested the build with 1.6? I am a little bit worried of hard-to-debug compile / runtime exceptions.

Copy link
Contributor Author

@VonUniGE VonUniGE Nov 28, 2021 •
edited
Loading

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

In my opinion, the risk is limited. It all depends on your context, if this is for a development environment the risk is acceptable, if this is for a mission critical application, you should buy a server license and use the official build.

Maybe we can add a sentence in the caveats section about this ?

Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

There's no need; that caveat would apply to everything we ship.

@carlocab carlocab mentioned this pull request Nov 26, 2021
Closed
6 tasks
@carlocab
Copy link
Member

Linux failed with:

       [exec] testsuite.c:21:29: fatal error: CUnit/Automated.h: No such file or directory
       [exec] compilation terminated.
       [exec] test_example.c:15:25: fatal error: CUnit/Basic.h: No such file or directory
       [exec] compilation terminated.
       [exec] test_javaadditionalparam.c:15:25: fatal error: CUnit/Basic.h: No such file or directory
       [exec] compilation terminated.
       [exec] test_hashmap.c:15:25: fatal error: CUnit/Basic.h: No such file or directory
       [exec] compilation terminated.
       [exec] test_filter.c:15:25: fatal error: CUnit/Basic.h: No such file or directory
       [exec] compilation terminated.
       [exec] wrapper.c:52:25: fatal error: CUnit/Basic.h: No such file or directory
       [exec] compilation terminated.
       [exec] make: *** [testsuite] Error 1
       [exec] make: *** Waiting for unfinished jobs....
       [exec] Makefile-linux-x86-64.make:44: recipe for target 'testsuite' failed

@iMichka
Copy link
Member

iMichka commented Nov 26, 2021

Yes, you need to add depends_on "cunit" => :build for Linux only.

carlocab
carlocab approved these changes Nov 28, 2021
View reviewed changes
Copy link
Member

@carlocab carlocab left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks, @VonUniGE!

@BrewTestBot
Copy link
Member

:shipit: @carlocab has triggered a merge.

@github-actions github-actions bot added the outdated PR was locked due to age label Dec 29, 2021
@github-actions github-actions bot locked as resolved and limited conversation to collaborators Dec 29, 2021
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Reviewers

@iMichka iMichka iMichka left review comments

@carlocab carlocab carlocab approved these changes

Assignees
No one assigned
Labels
CI-no-fail-fast Continue CI tests despite failing GitHub Actions matrix builds. java Java use is a significant feature of the PR or issue new formula PR adds a new formula to Homebrew/homebrew-core outdated PR was locked due to age
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
4 participants
@VonUniGE @carlocab @iMichka @BrewTestBot